Do we still need "git remote checking" during deploy?

TangRufus · June 8, 2018, 12:03pm

roots/trellis/blob/e140c05e18db87bce01d92bd1433c17e415adac3/roles/deploy/tasks/update.yml#L16-L33


- name: Check whether project source path is a git repo
stat:
  path: "{{ project_source_path }}/.git"
register: git_project


- name: Get current git remote URL
command: git config --get remote.origin.url
args:
  chdir: "{{ project_source_path }}"
register: remote_origin_url
when: git_project.stat.exists
changed_when: false


- name: Update git remote URL
command: git remote set-url origin {{ project_git_repo }}
args:
  chdir: "{{ project_source_path }}"
when: git_project.stat.exists and remote_origin_url.stdout != project_git_repo

These lines were introduced in #299.

As recent Ansible versions are able to detect/handle git remote changes, do we still need those git remote checking during deploy?

Perhaps adding force: yes to the Clone project files task is enough to replace all the above lines?

swalkinshaw · June 10, 2018, 3:20pm

Good catch. I’m pretty sure it can be removed. It can be verified with the steps that @fullyint mentioned in that PR as well.

TangRufus · June 10, 2018, 4:37pm

See: https://github.com/roots/trellis/pull/999