I think image minification and fonts gulp tasks should be gone

[Jon_Clawson]

I agree totally. I have used php to compile and minify before this and never had to deal with so much waiting. And sage takes up more space then the entire wordpress site. It feels like towing a bicycle with a tractor. I would suppose there is a way to slim down the processing and dependencies but have not had the time to look into it.

[gnowland]

@kalenjohnson

Everything from assets get’s compiled and placed in to dist, that’s about it.

…except .svg’s and .mp4’s… so how the hell do you reference those from the css? (not a rhetorical question, I desperately need to know)!

[kalenjohnson]

svg’s shouldn’t be ignored, at least not in the latest versions of Sage.

For mp4’s, yes it’s true that’s not handled by the gulpfile/asset builder. However, why couldn’t you reference the video directly from the assets directory?

At the moment the types of files to pass aren’t editable via manifest.json, so best option would be to reference the file outside of dist

Issue: add ability for user to extend built in types

[gnowland]

@kalenjohnson

For mp4’s, yes it’s true that’s not handled by the gulpfile/asset builder. However, why couldn’t you reference the video directly from the assets directory?

I just wasn’t sure if doing ../../assets/foo/bar.biz was “best practice”. I’m introducing my team to Sage and it’s a little wonky to say "use ../foo/bar.biz for everything, except not these things, if you know what I mean

Not sure why my SVG’s aren’t appearing in dist/images, I’m using the latest Sage… My gulpfile is the same as the one in the main branch of the repo… must be aliens.

UPDATE: SVG gulp process working now, must have been a bug with the SVG file I was testing with. Cheers.

[kalenjohnson]

@gnowland

I just wasn’t sure if doing …/…/assets/foo/bar.biz was “best practice”. I’m introducing my team to Sage and it’s a little wonky to say "use …/foo/bar.biz for everything, except not these things, if you know what I mean

Sure, I can appreciate that. Video is a rather edge case though, so it wasn’t really thought of to put it into the asset builder. Especially since the node modules that are installed already equal quite a hefty download with all the image optimization modules.

You could potentially duplicate the “fonts” task in the gulp file and have it copy a video folder. That would allow you to keep the same workflow as the rest of the assets.

[gnowland]

@kalenjohnson

You could potentially duplicate the “fonts” task in the gulp file and have it copy a video folder. That would allow you to keep the same workflow as the rest of the assets.

You rock, I owe you a beverage of your choice. Thanks for taking the time to respond!