Multisite subdomain instructions out of date?

trellis
#1

Looking at the docs:

-  if Vagrant.has_plugin? 'vagrant-hostmanager'
-    config.hostsupdater.aliases = aliases
+  if Vagrant.has_plugin? 'landrush'
+    config.landrush.enabled = true
+    config.landrush.tld = config.vm.hostname
+
+    hostnames.each do |host|
+      config.landrush.host host, PRIVATE_IP
+    end
   else
-    puts 'vagrant-hostsupdater missing, please install the plugin:'
-    puts 'vagrant plugin install vagrant-hostsupdater'
+    puts 'landrush missing, please install the plugin:'
+    puts 'vagrant plugin install landrush'
   end

But the Vagrantfile in Trellis 0.9.9 has a different block for vagrant-hostmanager:

  if Vagrant.has_plugin? 'vagrant-hostmanager'
    config.hostmanager.enabled = true
    config.hostmanager.manage_host = true
    config.hostmanager.aliases = hostnames + redirects
  else
    fail_with_message "vagrant-hostmanager missing, please install the plugin with this command:\nvagrant plugin install vagrant-hostmanager"
  end

It looks like provisioning a local setup works properly if one just replaces that whole block, but I think the docs should be updated for clarification. Any objections to me submitting a PR?

1 Like
#2

I thought I’d done a PR on those docs already…

#3

Yeah sorry, looks out of date after some recent changes for better Windows support. A PR would be welcome :slight_smile:

1 Like
#4

:heavy_check_mark: PR submitted: https://github.com/roots/docs/pull/61

1 Like