The last word on Sage 9 Bootstrap 4 Navwalkers

[alwaysblank]

@AmirFarid

I also noticed that if i used your bootstrap navwalker then clean menus no longer work. The soil plugin doesn’t do anything to the menu.

Soil “cleans up” the menu by using its own Walker. Since you’re using @MWDelaney’s Walker, Soil’s is never used. That’s not a bug. If you feel like his plugin can be improved, I’m sure he’d be happy to review a pull request.

[AmirFarid]

ah, thats such a shame. its so nice and clean to have clean html. It would be nice if @MWDelaney could review this and get a clean nav walker working like the soil one. Sorry no idea on how to do a pull request at moment as i dont use github (yea major downside i know I should be using it!).

[MWDelaney]

That’s not a feature I’m planning to add at this point.

[alwaysblank]

@AmirFarid

Sorry no idea on how to do a pull request at moment as i dont use github (yea major downside i know I should be using it!).

No time like the present to learn! Git is an invaluable tool for development, and collaboration is the foundation of open software like Sage. Here’s a good guide to help you learn how pull requests work: How To Create a Pull Request on GitHub | DigitalOcean

[AmirFarid]

ah. such a shame. thank for letting me know. Perhaps it will get me to delve into it and have a go myself.

Thanks @alwaysblank yup will do. have been meaning too for ages. Just dont get the opportunity.

[AmirFarid]

so i was fiddling about trying to work out how to get bootsrap nav working with soil and found this:

How to restore the Bootstrap nav [walkthrough]

I recently put this together and have been meaning to share it here. It’s based on Soils clean nav and Michael Romero’s Sageextras plugin. Basic output looks like: - ul id="menu-main" class="navbar-nav mr-auto" - li class="nav-item menu-item menu-page-1" - a class="nav-link" It also supports drop downs. Setup should be pretty self explanatory, but I’m going to update my original post, or make a new one, this weekend. In the mean-time, header markup and instructions are in the full gi…

I actually commented on that post but must have missed it somehow. Anyways i used that custom nav walker and bootsrap nav works with clean menu links

[bonlando]

I’m wondering if this is the right place to ask this, but the active class is not being added to any menu items that are linked to a custom post type. Any clue why that is?

[daniel]

@MWDelaney Thanks for this – Works great! What is the best way to make the parent-level menu items as active links without worrying about this being over written during an upgrade to your script? We found this: https://medium.com/@oscarmwana/make-parent-link-clickable-in-bootstrap-wordpress-navigation-walker-61213063a1a0 - But it looks like this got overwritten at some point when one of our developers cloned the project.

Thanks in advance!

[MWDelaney]

Hi, @Daniel. Truly the best way to do this would be to fork the project and maintain that functionality yourself. Since top-level linking is not supported by Bootstrap, it’s not a priority in this project, and is likely to break (as you’ve found) when changes are made.

[daniel]

@MWDelaney Thank you sir!

[Frykky]

@AmirFarid have you resolved?

Is there a way to use bootstrap 4 nawalkers and soil?

[gishua]

@MWDelaney

/** * Primary Nav Menu arguments * @return array */ public function primarymenu() { $args = array( ‘theme_location’ => ‘primary_navigation’, … ‘walker’ => new wp_bootstrap4_navwalker() ); return $args; }

Hi there,
Thank you again for this! I can’t seem to get this to work out of the box. I have tried the controller way and adding namespace to the top as well, but to no avail. Any help would be appreciated.

Fatal error : Uncaught Error: Class ‘App\Controllers\wp_bootstrap4_navwalker’ not found in /www/sites/sage/wwwroot/wp-content/themes/mysage/app/Controllers/App.php:39

Thank you in advance,
Josh

[MWDelaney]

The info in this thread is a little out of date. Be sure to check the documentation at the repository here:

MWDelaney/sage-bootstrap4-navwalker

It looks like you need to change your walker from

...
    'walker'            => new wp_bootstrap4_navwalker()
...

to

...
    'walker'            => new \App\wp_bootstrap4_navwalker()
...

[gishua]

Thank you!!! This worked. Apologies.

[boothwise]

Is there a way to use bootstrap 4 nawalkers and soil?

@MWDelaney , has there been any additional thought toward this, or is there another method to do this? I would be grateful.

I’ve been trying to figure this out for a week to work with Soil, but no luck… Rookie

[MWDelaney]

Soil’s navwalker and this one are alternative tools. They’re not meant to work together and I don’t plan to add they as a feature at this time.

[boothwise]

Thank you for the reply, I really do appreciate your knowledge…

Can you recommend a way to still use Soil with the nice links, but not have a lengthy class “menu-item menu-item-type-post_type menu-item-object-page nav-item nav-item-18” utilizing this method?

Any help would be greatly appreciated – I have about 30+ links total and could definitely appreciate less bloat.

[mmirus]

Hey @boothwise - you probably need to create your own custom nav walker that combines the elements you want from each. Spending some time looking at the source of Michael’s BS nav walker and the soil nav walker will help you understand how they work and should give you all the insight you need.

[Jan-Klaas]

Does this still work with bootstrap 5?

[mattegg]

This is how I ended up doing it : https://thewpgeek.com/add-a-responsive-menu-in-sage/ I would be interested in anything I should change in the tutorial (especially if something is not best practice)