Error: Sage 10/Bud jQuery Match Height

christianmagill · March 30, 2022, 1:21pm

I’m running into a JavaScript error when adding the following library to my project Sage 10 project. I have used the library on countless Sage 9 projects without issue.

The error comes down to “require” being undefined on the following line…

github.com

liabru/jquery-match-height/blob/4e9149cf7796a0e922d9203bd0badd0087c9b7cd/jquery.matchHeight.js#L14

      
        
            * License: MIT
            */
            
            
;(function(factory) { // eslint-disable-line no-extra-semi
                'use strict';
                if (typeof define === 'function' && define.amd) {
                    // AMD
                    define(['jquery'], factory);
                } else if (typeof module !== 'undefined' && module.exports) {
                    // CommonJS
                    module.exports = factory(require('jquery'));
                } else {
                    // Global
                    factory(jQuery);
                }
            })(function($) {
                /*
                *  internal
                */
            
            
    var _previousResizeWidth = -1,

I’m wondering whether this would be an issue with Bud or the jQuery Match Height plugin. I didn’t see anything related in the docs or GitHub issues.

I’m using Sage 10.1.2

ben · March 30, 2022, 2:26pm

This isn’t an answer to the bug, but is there a reason why you’re using jQuery?

That plugin hasn’t been updated since 2018. It doesn’t seem reasonable to expect that to work with modern JS tooling.

christianmagill · March 30, 2022, 3:18pm

I mainly use jQuery for 3rd party plugins that require it. Our medical-related projects still require IE support, unfortunately, so I often prefer libraries that can work in that context as well.

ben · March 30, 2022, 4:01pm

If you can create a reduced test case with all the relevant details (such as any changes made to your Bud config) then please report this as a bug on the Bud repo

kellymears · March 31, 2022, 11:57am

Hey @christianmagill I’m pretty sure I know exactly what’s going on with your build.

You should be able to fix it with this addition to your bud config:

app.hooks.on("build.module.noParse", undefined);

I would argue that the this plugin isn’t exactly being a team player but if this build error ends up being commonplace enough I’ll modify bud defaults to be more conservative.

christianmagill · March 31, 2022, 3:53pm

Thanks!

That worked like a charm.