Sage trying to load jquery 1.12.1

MiquelAdell · March 2, 2016, 9:25am

Hi,

I have a new instalation of sage over VVV

I’m seeing a very strange error on the console:

Failed to load resource: the server responded with a status of 404 (OK)
main.js
https://ajax.googleapis.com/ajax/libs/jquery/1.12.1/jquery.min.js

The url does not exist.

I have another project that is loading
https://ajax.googleapis.com/ajax/libs/jquery/1.11.3/jquery.min.js
Without any problem

The strange thing is that the project with the error is working correctly and correctly includes a jquery from:
/wp-includes/js/jquery/jquery.js

I also can see, in both projects, a jQuery v2 on dist. It doesn’t seem to be a requirement from the other libraries I’m installing with bower and I’m not requiring it nominally at all.

I understood that roots switched back to jQuery v1 so I don’t know what that v2 does here.

Also it doesn’t seem to get used at all.

Does anyone have this 1.12.1 problem?
Where is the version of the jQuery sage uses specified?
Should I be worried about having so many jQueries?

Thanks!

ben · March 2, 2016, 2:55pm

Sage does nothing as far as jQuery versions goes.

github.com

roots/sage/blob/8d7bcee4c46173d11dd8ea9a06021d8c27891b64/lib/setup.php#L104


/**
* Theme assets
*/
function assets() {
 wp_enqueue_style('sage/css', Assets\asset_path('styles/main.css'), false, null);


 if (is_single() && comments_open() && get_option('thread_comments')) {
   wp_enqueue_script('comment-reply');
 }


 wp_enqueue_script('sage/js', Assets\asset_path('scripts/main.js'), ['jquery'], null, true);
}
add_action('wp_enqueue_scripts', __NAMESPACE__ . '\\assets', 100);

Are you also using Soil?

MiquelAdell · March 3, 2016, 8:03am

Hi @ben,

Yes, I am.

My require from composer.json looks like this:

"require": {
    "php": ">=5.4.0",
    "composer/installers": "~1.0",
    "roots/soil": "3.6.2",
    "wpackagist-plugin/wp-migrate-db": "^0.7.2",
    "jjgrainger/wp-custom-post-type-class": "^1.4",
    "wpackagist-plugin/advanced-custom-fields": "^4.4",
    "wpackagist-plugin/post-type-switcher": "^1.5",
    "wpackagist-plugin/posts-to-posts": "^1.6",
    "wpackagist-plugin/advanced-excerpt": "^4.2.3",
    "roots/wp-password-bcrypt": "^1.0",
    "wpackagist-plugin/kau-boys-backend-localization": "^2.1"
  },

I guess the wrong jquery maybe comes from WordPress (using VVV an the nightly build of WP so maybe it comes from that).
I moved everything to the stable of WordPress on VVV and I don’t see the error any more.

This is my first project with VVV and I assumed I should use http://src.WordPress-develop.dev because it has “develop” on it. Maybe not XD

Thanks!

ben · March 3, 2016, 4:23pm

Soil tries to load the version of jQuery that core uses from the Google CDN, so if an upcoming WP ver is using one that doesn’t exist on the Google CDN then we’re going to run into issues

github.com

roots/soil/blob/master/modules/jquery-cdn.php#L12




namespace Roots\Soil\JqueryCDN;


/**
* Load jQuery from jQuery's CDN with a local fallback
*
* You can enable/disable this feature in functions.php (or lib/setup.php if you're using Sage):
* add_theme_support('soil-jquery-cdn');
*/
function register_jquery() {
 $jquery_version = wp_scripts()->registered['jquery']->ver;


 wp_deregister_script('jquery');


 wp_register_script(
   'jquery',
   'https://code.jquery.com/jquery-' . $jquery_version . '.min.js',
   [],
   null,
   true
 );

HongPong · June 21, 2019, 8:19pm

if jQuery is not working (404 missing request to remote server) go to app/setup.php and disable this line. seems relevant to add now - you won’t get the benefit of the CDN but it should work normally.

add_theme_support('soil-jquery-cdn');

MiquelAdell · June 25, 2019, 6:51am

Sorry I did not close that. It was a problem with wordpress and jquery versions. Updating wordpress solved that.

Thanks to all!