Should I be adding vendor/ directory to gitignore?

bedrock
1

I’m having a problem where in production my tinymce editor isn’t loading properly.
Wondering if somethign isn’t lining up.

Looked at the physical server files and the correct files are there. At least, all the files that are also on my dev environment.

"NetworkError: 404 Not Found - http://wccd.swodev.com/wp/wp-includes/js/tinymce/langs/en.js?ver=359-20131026"
en.js?...0131026
Failed to load: http://wccd.swodev.com/wp/wp-includes/js/tinymce/langs/en.js
wp-tin...0131026 (line 1)
"NetworkError: 404 Not Found - http://wccd.swodev.com/wp/wp-includes/js/tinymce/themes/advanced/langs/en.js?ver=359-20131026"
en.js?...0131026
Failed to load: http://wccd.swodev.com/wp/wp-includes/js/tinymce/themes/advanced/langs/en.js
wp-tin...0131026 (line 1)
2

If you’re using Bedrock, the vendor directory is already in the .gitignore file. And yes, any time you use a package manager, whether that’s Composer, NPM, or Bower, you should not have those packages in your repository.

From the looks of your error though, the browser is failing to load files from the Wordpress installation. I’m not sure exactly what that would be.

3

Well, I had overwrote my gitignore for some reason.
Fixed that, git rm’d all the vendor files.
Then, deployed again and it’s same issue… :-/

Hmmm :frowning:

Isn’t doing this on my other bedrock sites before the “web/” path change.
Not saying that’s why, but dunno… :-/

4

The wp folder should also be gitignored. Anything that is loaded by Composer should not be in your repository. So that would include the vendor dir, the wp dir, and any plugins installed by wpackagist in the plugin dir.

5

Well… it’s working now, must have been browser cache. Some days I’m such a n00b :smile: