Hi there,
On my site I’m using jQuery ajax to load more posts:
$.ajax({
url : window.wp.ajax_url,
type: 'post',
data: {
action: 'load_more_work',
skip,
load,
pageId,
lang
},
success: (response) => {
// show new posts
}
error: (jqXHR, error) => {
console.log(jqXHR.responseText, error);
}
});
In my functions.php :
add_action('wp_ajax_nopriv_load_more_work', 'loadMoreWork');
add_action('wp_ajax_load_more_work', 'loadMoreWork');
public function loadMoreWork() {
if (isset($_REQUEST['pageId'])) {
$id = $_REQUEST['pageId'];
// What should I call here to re-init soil root_relative_url?
// do_action('after_setup_theme', '\\Roots\\Soil\\load_modules', 100);
$work_ids = get_field('featured_work', $id);
$work_cases = getWorkCases($work_ids);
$data = Timber::compile('partials/blocks/b-cases.twig', ['work' => $work_cases['cases']]));
echo wp_send_json_success($data);
wp_die();
}
}
function getWorkCases($ids = []) {
$cases = [];
if ($ids) {
foreach ($ids as $id) {
$cases[] = array(
// permalink is not relative?
'permalink' => apply_filters('the_permalink', get_permalink($id))
);
}
}
return $cases;
}
However the returned permalinks are not relative in my ajax action. They are relative when I call my getWorkCases function normally.
Should I somehow re-init any filters or actions in order to make Soil’s relative url’s work with ajax?
Thanks!
I think the reason may be due to this line here:
/**
* Root relative URLs
*
* WordPress likes to use absolute URLs on everything - let's clean that up.
* Inspired by http://www.456bereastreet.com/archive/201010/how_to_make_wordpress_urls_root_relative/
*
* You can enable/disable this feature in functions.php (or app/setup.php if you're using Sage):
* add_theme_support('soil-relative-urls');
*/
if (is_admin() || isset($_GET['sitemap']) || in_array($GLOBALS['pagenow'], ['wp-login.php', 'wp-register.php'])) {
return;
}
$root_rel_filters = apply_filters('soil/relative-url-filters', [
'bloginfo_url',
'the_permalink',
'wp_list_pages',
'wp_list_categories',
'wp_get_attachment_url',
'the_content_more_link',
Try changing it to this:
if ((is_admin() && ! wp_doing_ajax()) || isset($_GET['sitemap']) || in_array($GLOBALS['pagenow'], ['wp-login.php', 'wp-register.php'])) {
If that works then you’ll need to open the issue on the GitHub repo.
Thanks!is_admin call is probably the issue indeed!
Unfortunately, this didn’t fix it.
If I log the booleans is_admin() and wp_doing_ajax() in my loadMoreWork ajax action, they’re both true so I understand why the Soil relative url’s wouldn’t work, but that conditional is only exectued once it seems. Even if I remove the whole is_admin check, it still doesn’t work.
I think the Soil module needs to be re-initialized somehow in Ajax?
However, if I use the root_relative_url function directly in my getWorkCases function, it does return the relative url in my ajax action:
'permalink' => \Roots\Soil\Utils\root_relative_url(get_permalink($id))
This fixes it for now, but I guess this should be wrapped in a conditional to check if Soil relative url’s are activated…
There’s another is_admin check here:
$this->options = $options;
}
}
require_once __DIR__ . '/lib/utils.php';
function load_modules() {
global $_wp_theme_features;
// Skip loading modules in the admin.
if (is_admin()) {
return;
}
foreach (glob(__DIR__ . '/modules/*.php') as $file) {
$feature = 'soil-' . basename($file, '.php');
if (isset($_wp_theme_features[$feature])) {
Options::init($feature, $_wp_theme_features[$feature]);
require_once $file;
}
}
Does removing that or including ! wp_doing_ajax() help?
Yup that did the trick!is_admin is checked, wp_doing_ajax should be excluded!
Do you want me to make a PR on Github?
No problem.
Definitely worth submitting and issue and PR for that
system
August 5, 2019, 9:39am
8
This topic was automatically closed after 42 days. New replies are no longer allowed.
